Re: [Xen-devel] [PATCH 13 of 17] docs: generate an index for the html output

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2011-11-25 at 12:22 +0000, Ian Jackson wrote:
> Ian Campbell writes ("Re: [Xen-devel] [PATCH 13 of 17] docs: generate an 
> index for the html   output"):
> > On Thu, 2011-11-24 at 17:42 +0000, Ian Jackson wrote:
> > >     next unless m/\S/;
> > 
> > I think that would be a syntax error so die unless m/\S/ ?
> 
> Surely ignoring blank lines is going to be less irritating.

I missed that this was \S not \s. Your way does indeed make sense.

> > > This is not correct because $outdir is not a regular expression.  The
> > > shortest way of doing this is indeed substr.
> > 
> > OK.
> > 
> > Aside: how does one dynamically construct a regex then?
> 
> However you like.  Make a variable which contains your regexp.  If you
> have a string in a scalar and want a regexp which matches that string
> you can do this:
>    my $regexp = $string;
>    $regexp =~ s/\W/\\$&/g;
>    ... m/^$regexp/ ...

Ah, I thought you were suggesting that /$something/ was not valid at
all, but you meant only if you don't correctly quote it etc.

Thanks,
Ian.

> 
> > > Do we really want an index per subdirectory ?
> > 
> > I was thinking of folks how manually type urls or who string the last
> > element off. Having an index in each dir ensures they get something
> > structured and not the apache generated thing.
> 
> True.
> 
> > It does complicate the code though so I could be convinced to drop it.
> 
> No, that's OK.
> 
> Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel