[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 1 of 4] Improve ring management for memory events


  • To: "Olaf Hering" <olaf@xxxxxxxxx>
  • From: "Andres Lagar-Cavilla" <andres@xxxxxxxxxxxxxxxx>
  • Date: Thu, 24 Nov 2011 10:54:44 -0800
  • Cc: andres@xxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxx, tim@xxxxxxx, keir.xen@xxxxxxxxx, adin@xxxxxxxxxxxxxx
  • Delivery-date: Thu, 24 Nov 2011 18:55:24 +0000
  • Domainkey-signature: a=rsa-sha1; c=nofws; d=lagarcavilla.org; h=message-id :in-reply-to:references:date:subject:from:to:cc:reply-to :mime-version:content-type:content-transfer-encoding; q=dns; s= lagarcavilla.org; b=hX66BZWAAXxK1KjS9oRTBMcMCmwqH679EoGU6grvcP7A L4iArgJmQODhTZfbeUd+qwvw5KmI7PZ5ZA9a/Aje9qVrtu+RCtO9z81LrHmQdLgx eW1pOAoSfSEzBccumyRiILHkyx6OaHib69KXjoXrEwab/D6XEIMYqr9HRTtkD5A=
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>

> On Wed, Nov 23, Andres Lagar-Cavilla wrote:
>
>> Well, we can tone down printk's to be debug level. I don't think they're
>> unnecessary if they're made an optional debug tool.
>
> There is nothing to debug here, since the callers have to retry anyway.
>
>> Question: I have one vcpu, how do I fill up the ring quickly? (outside
>> of
>> foreign mappings)
>
> Have a balloon driver in the guest and balloon down more than
> 64*PAGE_SIZE. This is the default at least in my setup where the kernel
> driver releases some memory right away (I havent checked where this is
> actually configured).

I see, a guest can call decrease_reservation with an extent_order large
enough that it will overflow the ring. No matter the size of the ring.
Isn't preemption of this hypercall a better tactic than putting the vcpu
on a wait-queue? This won't preclude the need for wait queues, but it
feels like a much cleaner solution.

With retrying of foreign mappings in xc_map_foreign_bulk (and grants), I
wonder if we should put events in the ring due to foreign mappings *at
all*, in the case of congestion. Eventually a retry will get to kick the
pager.

Andres

>
> Olaf
>



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.