Re: [Xen-devel] [PATCH 07 of 14] Trivial fix for rc val in hap track dirty vram

["Jan Beulich" <JBeulich@xxxxxxxx>]

 >>> On 23.11.11 at 22:11, Andres Lagar-Cavilla <andres@xxxxxxxxxxxxxxxx> wrote:
> xen/arch/x86/mm/hap/hap.c |  2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> 
> Signed-off-by: Andres Lagar-Cavilla <andres@xxxxxxxxxxxxxxxx>
> 
> diff -r e22610ef339a -r 25d27decfdcc xen/arch/x86/mm/hap/hap.c
> --- a/xen/arch/x86/mm/hap/hap.c
> +++ b/xen/arch/x86/mm/hap/hap.c
> @@ -141,7 +141,7 @@ int hap_track_dirty_vram(struct domain *
>          }
>          else if ( !paging_mode_log_dirty(d) && !dirty_vram )
>          {
> -            rc -ENOMEM;
> +            rc = -ENOMEM;
>              if ( (dirty_vram = xmalloc(struct sh_dirty_vram)) == NULL )
>                  goto param_fail;
>  

This would have been caught by the compiler if we weren't forcing
-Wno-unused-value. Keir, shouldn't we revisit this 5 year old decision
(c/s 11762:db3d58d30e9d)?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel