Re: [Xen-devel] [PATCH v8 0/6] build upstream qemu and seabios by default

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Tue, 18 Oct 2011, Ian Jackson wrote:
> Stefano Stabellini writes ("[Xen-devel] [PATCH v8 0/6] build upstream qemu 
> and seabios by default"):
> > Hi all,
> > this is the eighth version of the patch series to introduce upstream qemu
> > and seabios in the xen-unstable build system.
> 
> I tried this series.  I built my tree with this in .config
>   CONFIG_QEMU=/u/iwj/work/1/qemu-iwj.git
>   QEMU_UPSTREAM_URL=/u/iwj/work/1/qemu-upstream-unstable.git
> 
> I then found that the directory qemu-upstream-unstable.git contained a
> symlink qemu-upstream-unstable.git linking to the directory (by full
> pathname).

Yes, it has been the case since the early versions of this patch series.
Now I have fixed the out of tree build in upstream qemu so we can do the
same thing we are already doing with qemu-xen-traditional.


> It also had "linux-headers/asm" which wasn't covered by
> .gitignore.

It's a bug in qemu's "make clean". I'll work on it in the qemu tree. FYI
git clean works very well :)


> The xen-unstable-tools.hg tree I built it in also ended up with an
> awful lot of
>  ? tools/firmware/seabios-dir-remote/*

That is due to a typo in patch #5, it is fixed now.


> Can you please test:
> 
>  * That setting CONFIG_QEMU and QEMU_UPSTREAM_URL and
>    SEABIOS_UPSTREAM_URL (work whether they are set to URLs or
>    directories)

I have already tested this before sending v8 to the list


>  * That after building the dists/ tree looks as you would expect
>    (compare it with a dists/ tree from before your series)

done

>  * That setting {QEMU_UPSTREAM,SEABIOS_UPSTREAM,QEMU}_TAG still works
>    afterwards.

The behaviour is unchanged since before the patch series.

>  * That "make clean" cleans up everything that "make" creates except
>    for things which you deliberately decide it shouldn't

done (apart from the aforementioned bug in qemu's "make clean")


>  * That everything that "make" creates is mentioned in the
>    appropriate ignore files

done

>  * That a 2nd "make" doesn't do a lot of needless work

done

>  * That machinery is provided for pulling included trees eg
>    analagous to
>      make tools/ioemu-dir-force-update

Added to patch #4

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel