Re: [Xen-devel] [PATCH 2 of 3] RFC: mem_event: use wait queue when ring is full

[Keir Fraser <keir@xxxxxxx>]

On 23/11/2011 09:44, "Jan Beulich" <JBeulich@xxxxxxxx> wrote:

>>>> + /* VCPU is blocked on mem_paging ring. */
>>>> +#define _VPF_me_mem_paging   4
>>>> +#define VPF_me_mem_paging    (1UL<<_VPF_me_mem_paging)
>>>> + /* VCPU is blocked on mem_access ring. */
>>>> +#define _VPF_me_mem_access   5
>>>> +#define VPF_me_mem_access    (1UL<<_VPF_me_mem_access)
>>> 
>>> Same here - the mem_ seems superfluous.
>> 
>> Mem_event-related flags in a more general grouping do require a mem_ prefix
>> imo. The names need to stand on their own and still be descriptive.
> 
> But me_mem_ is still bogus - I thought the me_ stands for "mem event",
> and then the subsequent mem_ is unnecessary.

I'd get rid of the me_ rather than the mem_. The me_ is too short to be
meaningful really.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel