Re: [Xen-devel] [PATCH] xen-netfront: report link speed to ethtool

[David Miller <davem@xxxxxxxxxxxxx>]

From: Ben Hutchings <bhutchings@xxxxxxxxxxxxxx>
Date: Fri, 18 Nov 2011 17:46:34 +0000

> On Fri, 2011-11-18 at 17:48 +0100, Olaf Hering wrote:
>> Add .get_settings function, return fake data so that ethtool can get
>> enough information. For some application like VCS, this is useful,
>> otherwise some of application logic will get panic.
>> The reported data refers to VMWare vmxnet.
>> 
>> Signed-off-by: Xin Wei Hu <xwhu@xxxxxxxx>
>> Signed-off-by: Chunyan Liu <cyliu@xxxxxxxx>
>> Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>
> 
> NAK, we should not just make things up.

Agreed, if you cannot determine the values with certainty do not
implement this method.

Fix the tools which cannot function without this information.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel