Re: [Xen-devel] [PATCH 2 of 9 v2] libxl: add support for image files for NetBSD

[Roger Pau Monnà <roger.pau@xxxxxxxxxxxxx>]

2011/11/18 Ian Campbell <Ian.Campbell@xxxxxxxxxx>:
> On Fri, 2011-11-18 at 11:59 +0000, Roger Pau Monne wrote:
>> # HG changeset patch
>> # User Roger Pau Monne <roger.pau@xxxxxxxxxxxxx>
>> # Date 1317386335 -7200
>> # Node ID 9e8abd626484f82a95d0edc07834ae287bc9467a
>> # Parent Â23578c9942bcc8767adc4e435bb1fd1cd89f5e18
>> libxl: add support for image files for NetBSD
>>
>> Created a helper function to detect if the OS is capable of using
>> image files as phy backends. Create two OS specific files, and
>> changed the Makefile to choose the correct one at compile time.
>>
>> Signed-off-by: Roger Pau Monne <roger.pau@xxxxxxxxxxxxx>
>>
>> diff -r 23578c9942bc -r 9e8abd626484 tools/libxl/Makefile
>> --- a/tools/libxl/Makefile  ÂFri Sep 30 14:38:55 2011 +0200
>> +++ b/tools/libxl/Makefile  ÂFri Sep 30 14:38:55 2011 +0200
>> @@ -32,6 +32,12 @@ endif
>> ÂLIBXL_OBJS-$(CONFIG_X86) += libxl_cpuid.o
>> ÂLIBXL_OBJS-$(CONFIG_IA64) += libxl_nocpuid.o
>>
>> +ifeq ($(CONFIG_NetBSD),y)
>> +LIBXL_OBJS-y += libxl_phybackend.o
>> +else
>> +LIBXL_OBJS-y += libxl_nophybackend.o
>
> phy vs nophy don't really make sense to me here, since in both cases the
> content relates to the phy backend.
>
> Perhaps we need libxl_$(OS).c to contain os specific stuff?

A libxl_$(OS).c sounds interesting, I could put hotplug and backend OS
specific code there, but I'm afraid it might get crowded and become
difficult to understand. If I don't receive any other suggestions, I
will create a libxl_netbsd.c and libxl_linux.c (and libxl_solaris.c?)
and place the hotplug and backend helper functions there.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel