[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] Re: [PATCH 1/3] xen/granttable: Introducing grant table V2 stucture





On 2011-11-18 0:29, Konrad Rzeszutek Wilk wrote:
The more normal way to do this would be to make gnttab_interface a
pointer, define gnttab_v1_ops and do:
        gnttab_interface =&gnttab_v1_ops;
or if the pointer overhead is significant remove that and just do a
struct assignment:
        gnttab_interface = gnttab_v1_ops;

If using this way, we need two more public structures(gnttab_v1_ops
and gnttab_v2_ops), and two more functions to initialize those two
structures and then initialize the pointer gnttab_interface. It is
more complicated, am i missing something?
Why two functions? I agree on the structures - but they need not to be
public (they can be static).

For a good example look at how apic_physflat is done.
Thanks, static structure is simpler and clean. I am very glad to change that.:-)

Thanks
Annie
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.