Re: [Xen-devel] [PATCH 0/4] docs/html/hcall: Hypercall docs headers

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("Re: [Xen-devel] [PATCH 0/4] docs/html/hcall: Hypercall 
doc> Excellent stuff.

Glad you like it.

> It seems to consider
>         static struct xsd_errors xsd_errors[]
>         #if defined(__GNUC__)
>         __attribute__((unused))
> as defining a function called __attribute__ which is a bit unfortunate!

I can fix that easily enough by special-casing keywords.

> I had some nitpicks as I looked over the patches but regardless I think
> this is a good start and should go in. All:
> Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

Thanks.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel