[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH 2/4] docs/html/hcall: Annotations for two hypercalls
Ian Campbell writes ("Re: [Xen-devel] [PATCH 2/4] docs/html/hcall: Annotations for two hypercalls"): > On Sun, 2011-11-13 at 19:21 +0000, Ian Jackson wrote: > > +/* ` enum neg_errnoval { /* -Efoo for each Efoo in the list below } */ > > Do we pass -Wcomment (or something which includes it)? If so gcc might > warn: > /home/ianc/t.c:5:26: warning: "/*" within comment > (and we use -Werror, so...). Good point. I don't think we pass that now - I would have noticed. But we probably should do so I should change the comment there to [ ] or something. > Is this syntax trying to encode some meaning or was it just a typo? Ideally it would have had a matching */ but obv. that wouldn't have worked :-). > > +/* ` enum errnoval { */ > > + > > #define EPERM 1 /* Operation not permitted */ > > #define ENOENT 2 /* No such file or directory */ > > #define ESRCH 3 /* No such process */ > > @@ -129,4 +132,6 @@ > > #define ENOMEDIUM 123 /* No medium found */ > > #define EMEDIUMTYPE 124 /* Wrong medium type */ > > > > +/* } */ > > Is the ` supposed to be required here or is omitting it fine? Omitting the ` means the processor doesn't see that which means the remaining #defines in that file would count as part of the enum - except there aren't any. So it's a bug. Ian. _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |