[Xen-devel] [PATCH 5/9] Decompressors: check for read errors in unlzma.c

["Jan Beulich" <JBeulich@xxxxxxxx>]

From: Lasse Collin <lasse.collin@xxxxxxxxxxx>

Return value of rc->fill() is checked in rc_read() and error() is called
when needed, but then the code continues as if nothing had happened.

rc_read() is a void function and it's on the top of performance critical
call stacks, so propagating the error code via return values doesn't sound
like the best fix.  It seems better to check rc->buffer_size (which holds
the return value of rc->fill()) in the main loop.  It does nothing bad
that the code runs a little with unknown data after a failed rc->fill().

This fixes an infinite loop in initramfs decompression if the
LZMA-compressed initramfs image is corrupt.

Signed-off-by: Lasse Collin <lasse.collin@xxxxxxxxxxx>
Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

--- a/xen/common/unlzma.c
+++ b/xen/common/unlzma.c
@@ -625,6 +625,8 @@ STATIC int INIT unlzma(unsigned char *bu
                        if (cst.rep0 == 0)
                                break;
                }
+               if (rc.buffer_size <= 0)
+                       goto exit_3;
        }
 
        if (posp)
@@ -632,6 +634,7 @@ STATIC int INIT unlzma(unsigned char *bu
        if (wr.flush)
                wr.flush(wr.buffer, wr.buffer_pos);
        ret = 0;
+exit_3:
        large_free(p);
 exit_2:
        if (!output)

Attachment: unlzma-check-read-errors.patch
Description: Text document

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel