[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH 2/6] iommu: Introduce iommu_flush and iommu_flush_all.
>>> On 07.11.11 at 16:16, Jean Guyader <jean.guyader@xxxxxxxxxxxxx> wrote: > Signed-off-by: Jean Guyader <jean.guyader@xxxxxxxxxxxxx> > --- > xen/drivers/passthrough/iommu.c | 20 ++++++++++++++++++++ > xen/drivers/passthrough/vtd/iommu.c | 12 ++++++++++++ > xen/include/xen/iommu.h | 5 +++++ > 3 files changed, 37 insertions(+), 0 deletions(-) In iommu_iotlb_flush() you check whether the to-be-called function pointer is NULL, whereas in iommu_iotlb_flush_all() you don't. I actually think the second behavior is the correct one, but that implies that you need to also implement respective AMD IOMMU functions. Jan _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |