Re: [Xen-devel] [PATCH 9 of 9] Modify all call sites of queries into the p2m to use the new fine-grained locking

["Andres Lagar-Cavilla" <andres@xxxxxxxxxxxxxxxx>]

get_gfn/put_gfn it is. I'll figure set_gfn/alternative on the way. Next
patch coming with that naming. It will make everyone cringe :)

Andres

> At 07:32 -0700 on 02 Nov (1320219175), andres@xxxxxxxxxxxxxxxx wrote:
>> I don't know that a massive sed on all these names is a good idea. I
>> guess
>> forcing everyone to compile-fail will also make them realize they need
>> to
>> add a call to drop the p2m locks they got...
>>
>> Can you elaborate on the naming preferences here: would you prefer
>> gfn_to_mfn/put_gfn? get_p2m_gfn/put_p2m_gfn? get_gfn/put_gfn
>
> I think I'd prefer get_gfn/put_gfn.  And maybe set_gfn for writes too?
> But I'm willing to be persuaded otherwise if anyone feels strongly about
> it.
>
> Tim.
>



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel