[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [Xen-devel] Ping: [PATCH] powernow: don't read never initialized structure member
c/s 20361:51b031b0737e removed the writing of struct processor_performance's shared_cpu_map member, but the powernow driver still has code to read it (though presumably that code path can't be taken on actual hardware supported by the powernow driver). Remove the use of the field along with the field itself. Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx> --- a/xen/arch/x86/acpi/cpufreq/powernow.c +++ b/xen/arch/x86/acpi/cpufreq/powernow.c @@ -200,16 +200,13 @@ static int powernow_cpufreq_cpu_init(str perf = data->acpi_data; policy->shared_type = perf->shared_type; - /* - * Will let policy->cpus know about dependency only when software - * coordination is required. - */ if (policy->shared_type == CPUFREQ_SHARED_TYPE_ALL || policy->shared_type == CPUFREQ_SHARED_TYPE_ANY) { - policy->cpus = perf->shared_cpu_map; - } else { - policy->cpus = cpumask_of_cpu(cpu); + printk("Unsupported sharing type\n"); + result = -ENODEV; + goto err_unreg; } + cpumask_copy(&policy->cpus, cpumask_of(cpu)); /* capability check */ if (perf->state_count <= 1) { --- a/xen/include/acpi/cpufreq/processor_perf.h +++ b/xen/include/acpi/cpufreq/processor_perf.h @@ -29,7 +29,6 @@ struct processor_performance { uint32_t state_count; struct xen_processor_px *states; struct xen_psd_package domain_info; - cpumask_t shared_cpu_map; uint32_t shared_type; uint32_t init; _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |