Re: [Xen-devel] [PATCH v6 1/5] Introduce git-checkout.sh

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

stefano.stabellini@xxxxxxxxxxxxx writes ("[Xen-devel] [PATCH v6 1/5] Introduce 
git-checkout.sh"):
> Introduce a script to perform git checkout on an external git tree; use
> git-checkout.sh in ioemu-dir-find.
...
> +#!/bin/sh
> +
> +TREE=$1
> +TAG=$2
> +DIR=$3

Missing
 - set -e
 - argument count check

> +if test \! -d $DIR-remote; then
> +     rm -rf $DIR-remote $DIR-remote.tmp;

Spurious semicolons.

>  distclean: subdirs-distclean
> -     rm -rf ioemu-dir ioemu-remote
> +     rm -rf ioemu-dir ioemu-dir-remote

Would it be too much to ask you not to rename this directory ?

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel