Re: [Xen-devel] [PATCH] xl: fixup "xl save" command line handling

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("[Xen-devel] [PATCH] xl: fixup "xl save" command line 
handling"):
> # HG changeset patch
> # User Ian Campbell <ian.campbell@xxxxxxxxxx>
> # Date 1315922772 -3600
> # Node ID 311080019e01809614dac0321b210ef1a9bbcb44
> # Parent  4309ff9535001bdca8db93a439edd86bb4c447cd
> xl: fixup "xl save" command line handling.
> 
> The save file paramter is required so ensure we have enough arguments.

Right.

> The config filename is optional so do not use argv[optind+3], which
> may well happen to be NULL when the paramter is not present but
> relying on that is pretty gross.

It is guaranteed that argv[argc]==NULL but I agree that this part of
the patch is a stylistic improvement.

Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
Committed-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel