Re: [Xen-devel] [PATCH] IRQ Cleanup: rename nr_ioapic_registers to nr_ioapic_entries

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 26.09.11 at 17:15, Andrew Cooper <andrew.cooper3@xxxxxxxxxx> wrote:
> On 26/09/11 15:57, Jan Beulich wrote:
>>>>> On 26.09.11 at 16:48, Andrew Cooper <andrew.cooper3@xxxxxxxxxx> wrote:
>>> The name "nr_ioapic_registers" is wrong and actively misleading.  The
>>> variable holds the number of redirection entries for each apic, which
>>> is two registers fewer than the total number of registers.
>> To be honest, this is the kind of renaming that I wouldn't want to do
>> as long as Linux, from where the code originates, continues to use
>> the prior name (no matter whether you consider it misleading).
>>
>> Jan
> 
> I guess it depends on whether you consider that we should stay in line
> with Linux or not.  While the code did start in Linux, it has diverged
> so far that it really is its own file now.
> 
> Either we should un-diverge from Linux (unlikely to happen), or consider
> it properly forked and not worry; staying in this intermediate state is
> not sustainable and leads to keeping misleading bits about while an
> overhaul is needed.

There's one more alternative: You could propose the same renaming
on Linux.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel