Re: [Xen-devel] Re: [PATCH] xen: change XEN_PLATFORM_PCI to bool default y

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 22.09.11 at 21:35, Jeremy Fitzhardinge <jeremy@xxxxxxxx> wrote:
> On 09/21/2011 11:21 PM, Ian Campbell wrote:
>> On Wed, 2011-09-21 at 23:49 +0100, Jeremy Fitzhardinge wrote:
>>>> That would work too. Even better would be to make it an invisible
>>>> Kconfig symbol which PVHVM just selects.
>>> Eh, select is pretty nasty.
>> Select of a non user visible symbol is perfectly fine. It's only when
>> you select something a user can also set that things get nasty.
> 
> It doesn't matter if its user-visible.  If the selected symbol acquires
> other dependencies, the selection won't set them.

Despite there being numerous contrary examples in the tree: Either one
wants a select-only symbol (then putting dependencies on it is wrong) or
one wants an automatic symbol (then selecting it is very likely wrong).
Which all boils down to the bogus mixing of normal (forward) and reverse
dependencies (using the kconfig source/doc wording).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel