[Xen-devel] Re: [PATCH RESEND V8 1/7] libxl: Rename libxl.idl to libxl_types.idl.

[Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>]

On Wed, 2011-09-21 at 13:59 +0100, Anthony PERARD wrote:
> Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

FWIW I acked v7 of this, collecting such acks in repostings of otherwise
unchanged patches helps reviewer skip over them...

> ---
>  tools/libxl/Makefile                       |   12 ++++++------
>  tools/libxl/{libxl.idl => libxl_types.idl} |    0
>  tools/ocaml/libs/xl/Makefile               |    4 ++--
>  tools/python/Makefile                      |    4 ++--
>  4 files changed, 10 insertions(+), 10 deletions(-)
>  rename tools/libxl/{libxl.idl => libxl_types.idl} (100%)
> 
> diff --git a/tools/libxl/Makefile b/tools/libxl/Makefile
> index 3eeb26f..330ee6e 100644
> --- a/tools/libxl/Makefile
> +++ b/tools/libxl/Makefile
> @@ -52,8 +52,8 @@ $(XL_OBJS): CFLAGS += $(CFLAGS_libxenctrl) # For 
> xentoollog.h
>  $(XL_OBJS): CFLAGS += $(CFLAGS_libxenlight)
>  
>  testidl.o: CFLAGS += $(CFLAGS_libxenctrl) $(CFLAGS_libxenlight)
> -testidl.c: libxl.idl gentest.py libxl.h
> -     $(PYTHON) gentest.py libxl.idl testidl.c.new
> +testidl.c: libxl_types.idl gentest.py libxl.h
> +     $(PYTHON) gentest.py libxl_types.idl testidl.c.new
>       mv testidl.c.new testidl.c
>  
>  .PHONY: all
> @@ -84,10 +84,10 @@ libxl.h: _libxl_types.h
>  
>  $(LIBXL_OBJS) $(LIBXLU_OBJS) $(XL_OBJS): libxl.h
>  
> -_libxl_%.h _libxl_%.c: libxl.idl gen%.py libxl%.py
> -     $(PYTHON) gen$*.py libxl.idl __libxl_$*.h __libxl_$*.c
> -     $(call move-if-changed,__libxl_$*.h,_libxl_$*.h)
> -     $(call move-if-changed,__libxl_$*.c,_libxl_$*.c)
> +_libxl_type%.h _libxl_type%.c: libxl_type%.idl gentypes.py libxltypes.py
> +     $(PYTHON) gentypes.py libxl_type$*.idl __libxl_type$*.h __libxl_type$*.c
> +     $(call move-if-changed,__libxl_type$*.h,_libxl_type$*.h)
> +     $(call move-if-changed,__libxl_type$*.c,_libxl_type$*.c)
>  
>  libxenlight.so: libxenlight.so.$(MAJOR)
>       ln -sf $< $@
> diff --git a/tools/libxl/libxl.idl b/tools/libxl/libxl_types.idl
> similarity index 100%
> rename from tools/libxl/libxl.idl
> rename to tools/libxl/libxl_types.idl
> diff --git a/tools/ocaml/libs/xl/Makefile b/tools/ocaml/libs/xl/Makefile
> index 342dc35..a1e79a5 100644
> --- a/tools/ocaml/libs/xl/Makefile
> +++ b/tools/ocaml/libs/xl/Makefile
> @@ -45,10 +45,10 @@ xl.mli: xl.mli.in _libxl_types.mli.in
>         < xl.mli.in > xl.mli.tmp
>       $(Q)mv xl.mli.tmp xl.mli
>  
> -_libxl_types.ml.in _libxl_types.mli.in _libxl_types.inc: genwrap.py 
> $(XEN_ROOT)/tools/libxl/libxl.idl \
> +_libxl_types.ml.in _libxl_types.mli.in _libxl_types.inc: genwrap.py 
> $(XEN_ROOT)/tools/libxl/libxl_types.idl \
>                  $(XEN_ROOT)/tools/libxl/libxltypes.py
>       PYTHONPATH=$(XEN_ROOT)/tools/libxl $(PYTHON) genwrap.py \
> -             $(XEN_ROOT)/tools/libxl/libxl.idl \
> +             $(XEN_ROOT)/tools/libxl/libxl_types.idl \
>               _libxl_types.mli.in _libxl_types.ml.in _libxl_types.inc
>  
>  libs: $(LIBS)
> diff --git a/tools/python/Makefile b/tools/python/Makefile
> index de44178..b7bc501 100644
> --- a/tools/python/Makefile
> +++ b/tools/python/Makefile
> @@ -10,10 +10,10 @@ genpath-target = $(call buildmakevars2file,$(XENPATH))
>  $(eval $(genpath-target))
>  
>  .PHONY: build
> -build: genpath genwrap.py $(XEN_ROOT)/tools/libxl/libxl.idl \
> +build: genpath genwrap.py $(XEN_ROOT)/tools/libxl/libxl_types.idl \
>               $(XEN_ROOT)/tools/libxl/libxltypes.py
>       PYTHONPATH=$(XEN_ROOT)/tools/libxl $(PYTHON) genwrap.py \
> -             $(XEN_ROOT)/tools/libxl/libxl.idl \
> +             $(XEN_ROOT)/tools/libxl/libxl_types.idl \
>               xen/lowlevel/xl/_pyxl_types.h \
>               xen/lowlevel/xl/_pyxl_types.c
>       CC="$(CC)" CFLAGS="$(CFLAGS)" $(PYTHON) setup.py build



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel