[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [Xen-devel] netback commit history
Hi Ian, with the upstream netback introduction consisting of a single big commit I wonder whether you could point me to where the full history of it is. I'm asking particularly in the context of us being asked to add a safety check similar to the vif->netbk != NULL one at the beginning of xenvif_start_xmit() (also in xenvif_interrupt(), but there we have a similar check in place), which hadn't been in the legacy tree (obviously) nor in the original multiple-tasklets patch that I retained a copy of. That is, I'd like to understand the reasons for this check as it seems wrong to me to have to do it there - I'd rather think that if an interface got disabled, execution shouldn't even reach that function anymore. One thing I wonder about in this context is whether the netif_stop_queue() call from xenvif_close() shouldn't happen before xenvif_down() (not the least for reasons of symmetry with xenvif_open()). Thanks, Jan _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |