Re: [Xen-devel] [PATCH] libxl: add support for booting PV domains from NetBSD using raw files as disks. Fixed the shutdown race problem by checking "hotplug-status" instead of "state" xenstore variable in NetBSD

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2011-09-15 at 11:19 -0400, Roger Pau Monnà wrote:
> 2011/9/15 Ian Campbell <Ian.Campbell@xxxxxxxxxx>:
> > On Thu, 2011-09-15 at 09:03 -0400, Roger Pau Monne wrote:
> >> # HG changeset patch
> >> # User Roger Pau Monne <roger.pau@xxxxxxxxxxxxx>
> >> # Date 1316091721 -7200
> >> # Node ID 015617579cd36fc58318aaf350bec5f7cc07ef2f
> >> # Parent  63e254468d6e8d81baeafaed68f05791dc21eb4e
> >> libxl: add support for booting PV domains from NetBSD using raw files
> >> as disks. Fixed the shutdown race problem by checking "hotplug-status"
> >> instead of "state" xenstore variable in NetBSD.
> >
> > This was one long line which mercurial will use as a summary, it's a
> > good idea to make sure that the first line stands somewhat alone as a
> > summary so the e.g. "hg log" is useful.
> > Also this sounds on the face of it like two bugfixes, if that's the case
> > they should be submitted separately.
> 
> Well, it's not a bugfix, because NetBSD was not supported by libxl, so
> I think it's just part of the patch to add support for NetBSD to
> libxl. I will split the line, and the patch if it's necessary, but one
> doesn't make sense without the other, and I don't really know what
> would be in each patch.

I guess I saw "add support" and "fix race" and assumed they were
separate (albeit related) changes.

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel