[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Xen-devel] Re: [PATCH 08/13] xen/pvticketlock: disable interrupts while blocking
- To: Don Zickus <dzickus@xxxxxxxxxx>
- From: Avi Kivity <avi@xxxxxxxxxx>
- Date: Wed, 14 Sep 2011 10:00:07 +0300
- Cc: Jeremy Fitzhardinge <jeremy@xxxxxxxx>, Marcelo Tosatti <mtosatti@xxxxxxxxxx>, Nick Piggin <npiggin@xxxxxxxxx>, KVM <kvm@xxxxxxxxxxxxxxx>, Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>, Peter Zijlstra <peterz@xxxxxxxxxxxxx>, the arch/x86 maintainers <x86@xxxxxxxxxx>, Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>, Andi Kleen <andi@xxxxxxxxxxxxxx>, Jeremy Fitzhardinge <jeremy.fitzhardinge@xxxxxxxxxx>, "H. Peter Anvin" <hpa@xxxxxxxxx>, Ingo Molnar <mingo@xxxxxxx>, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>, Xen Devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
- Delivery-date: Wed, 14 Sep 2011 00:04:50 -0700
- List-id: Xen developer discussion <xen-devel.lists.xensource.com>
On 09/13/2011 10:21 PM, Don Zickus wrote:
Or are you saying an NMI in an idle system will have the same %rip thus
falsely detecting a back-to-back NMI?
That's easy to avoid - insert an instruction zeroing the last nmi_rip
somewhere before or after hlt. It's always okay to execute such an
instruction (outside the nmi handler itself), since nmi_rip is meant to
detect a "no instructions executed" condition.
--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
