Re: [Xen-devel] [PATCH v2 4/4] Clone and build Seabios by default

[George Dunlap <dunlapg@xxxxxxxxx>]

On Fri, Sep 9, 2011 at 11:19 AM, Stefano Stabellini
<stefano.stabellini@xxxxxxxxxxxxx> wrote:
> On Thu, 8 Sep 2011, Ian Campbell wrote:
>> On Thu, 2011-09-08 at 13:47 -0400, stefano.stabellini@xxxxxxxxxxxxx
>> wrote:
>> > Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
>> >
>> > diff -r ef27b472d4f3 Config.mk
>> > --- a/Config.mk     Thu Sep 08 17:19:12 2011 +0000
>> > +++ b/Config.mk     Thu Sep 08 17:29:50 2011 +0000
>> > @@ -195,6 +195,8 @@ endif
>> >  # Only available through the git protocol at the moment
>> >  QEMU_UPSTREAM_URL ?= git://xenbits.xen.org/people/sstabellini/qemu-dm.git
>> >  QEMU_UPSTREAM_TAG ?= origin/xen-stable-0.15
>> > +SEABIOS_UPSTREAM_URL=git://git.qemu.org/seabios.git
>> > +SEABIOS_UPSTREAM_TAG ?= 7fc039e9c262b4199fab497f3e12f4e425c37560
>>
>> I guess we should have a default tree on xenbits for this?
>
> I am not sure it is a good idea, after all we don't plan to fork it,
> right?
> It is the same thing as with ipxe: we just use the official repo.

But that means that if the sites hosting ipxe or qemu go down, people
can't build Xen.  Keeping a copy on xen.org removes external
dependencies we don't have any control over.

>
>
>
>> [...]
>> > +$(SEABIOS_DIR):
>> > +   set -ex; \
>> > +   if [ ! -d seabios-remote ]; then \
>> > +           rm -rf seabios-remote seabios-remote.tmp; \
>> > +           mkdir seabios-remote.tmp; rmdir seabios-remote.tmp; \
>> > +           $(GIT) clone $(SEABIOS_UPSTREAM_URL) seabios-remote.tmp; \
>> > +           if [ "$(SEABIOS_UPSTREAM_TAG)" ]; then                  \
>> > +                   cd seabios-remote.tmp;                  \
>> > +                   $(GIT) branch -D dummy >/dev/null 2>&1 ||:; \
>> > +                   $(GIT) checkout -b dummy $(SEABIOS_UPSTREAM_TAG);     
>> >   \
>> > +                   cd ..;                                  \
>> > +           fi;                                             \
>> > +           mv seabios-remote.tmp seabios-remote; \
>> > +   fi; \
>> > +   rm -f seabios-dir; \
>> > +   ln -sf seabios-remote seabios-dir; \
>> > +   cp seabios-config seabios-dir/.config;
>>
>> This looks a lot like the qemu stuff which you only just moved into its
>> own script. Can we not share it?
>
> Yep, I'll do that.
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel
>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel