# HG changeset patch # Parent 589651f9a8a62fa25dc062b5b23a0ce947a259a5 diff -r 589651f9a8a6 xen/arch/x86/hpet.c --- a/xen/arch/x86/hpet.c Thu Aug 25 17:50:48 2011 +0100 +++ b/xen/arch/x86/hpet.c Fri Aug 26 19:26:59 2011 +0100 @@ -325,7 +325,7 @@ static void hpet_msi_ack(unsigned int ir ack_APIC_irq(); } -static void hpet_msi_end(unsigned int irq) +static void hpet_msi_end(unsigned int irq, u8 vector) { } diff -r 589651f9a8a6 xen/arch/x86/i8259.c --- a/xen/arch/x86/i8259.c Thu Aug 25 17:50:48 2011 +0100 +++ b/xen/arch/x86/i8259.c Fri Aug 26 19:26:59 2011 +0100 @@ -91,7 +91,7 @@ static unsigned int startup_8259A_irq(un return 0; /* never anything pending */ } -static void end_8259A_irq(unsigned int irq) +static void end_8259A_irq(unsigned int irq, u8 vector) { if (!(irq_desc[irq].status & (IRQ_DISABLED|IRQ_INPROGRESS))) enable_8259A_irq(irq); diff -r 589651f9a8a6 xen/arch/x86/io_apic.c --- a/xen/arch/x86/io_apic.c Thu Aug 25 17:50:48 2011 +0100 +++ b/xen/arch/x86/io_apic.c Fri Aug 26 19:26:59 2011 +0100 @@ -1657,7 +1657,7 @@ static void mask_and_ack_level_ioapic_ir } } -static void end_level_ioapic_irq (unsigned int irq) +static void end_level_ioapic_irq (unsigned int irq, u8 vector) { unsigned long v; int i; @@ -1706,6 +1706,14 @@ static void end_level_ioapic_irq (unsign */ i = IO_APIC_VECTOR(irq); + /* CA-65000 - manually EOI the old vector if we are moving to the new */ + if ( vector && i != vector ) + { + int ioapic; + for (ioapic = 0; ioapic < nr_ioapics; ioapic++) + io_apic_eoi(ioapic, i); + } + v = apic_read(APIC_TMR + ((i & ~0x1f) >> 1)); ack_APIC_irq(); @@ -1729,7 +1737,7 @@ static void disable_edge_ioapic_irq(unsi { } -static void end_edge_ioapic_irq(unsigned int irq) +static void end_edge_ioapic_irq(unsigned int irq, u8 vector) { } @@ -1780,7 +1788,7 @@ static void ack_msi_irq(unsigned int irq ack_APIC_irq(); /* ACKTYPE_NONE */ } -static void end_msi_irq(unsigned int irq) +static void end_msi_irq(unsigned int irq, u8 vector) { if ( !msi_maskable_irq(irq_desc[irq].msi_desc) ) ack_APIC_irq(); /* ACKTYPE_EOI */ @@ -1833,7 +1841,7 @@ static void ack_lapic_irq(unsigned int i ack_APIC_irq(); } -static void end_lapic_irq(unsigned int irq) { /* nothing */ } +static void end_lapic_irq(unsigned int irq, u8 vector) { /* nothing */ } static hw_irq_controller lapic_irq_type = { .typename = "local-APIC-edge", diff -r 589651f9a8a6 xen/arch/x86/irq.c --- a/xen/arch/x86/irq.c Thu Aug 25 17:50:48 2011 +0100 +++ b/xen/arch/x86/irq.c Fri Aug 26 19:26:59 2011 +0100 @@ -349,6 +349,7 @@ static void __do_IRQ_guest(int vector); void no_action(int cpl, void *dev_id, struct cpu_user_regs *regs) { } static void enable_none(unsigned int vector) { } +static void end_none(unsigned int irq, u8 vector) { } static unsigned int startup_none(unsigned int vector) { return 0; } static void disable_none(unsigned int vector) { } static void ack_none(unsigned int irq) @@ -357,7 +358,6 @@ static void ack_none(unsigned int irq) } #define shutdown_none disable_none -#define end_none enable_none hw_irq_controller no_irq_type = { "none", @@ -385,6 +385,7 @@ int __assign_irq_vector(int irq, struct static int current_vector = FIRST_DYNAMIC_VECTOR, current_offset = 0; unsigned int old_vector; int cpu, err; + unsigned long flags; cpumask_t tmp_mask; /* If we already have a vector on one of the cpus in the mask, @@ -437,6 +438,7 @@ next: /* Found one! */ current_vector = vector; current_offset = offset; + local_irq_save(flags); if (old_vector) { cfg->move_in_progress = 1; cpus_copy(cfg->old_cpu_mask, cfg->cpu_mask); @@ -467,6 +469,7 @@ next: if (IO_APIC_IRQ(irq)) irq_vector[irq] = vector; err = 0; + local_irq_restore(flags); break; } return err; @@ -674,7 +677,7 @@ asmlinkage void do_IRQ(struct cpu_user_r desc->status &= ~IRQ_INPROGRESS; out: - desc->handler->end(irq); + desc->handler->end(irq, regs->entry_vector); out_no_end: spin_unlock(&desc->lock); irq_exit(); @@ -890,7 +893,7 @@ static void irq_guest_eoi_timer_fn(void switch ( action->ack_type ) { case ACKTYPE_UNMASK: - desc->handler->end(irq); + desc->handler->end(irq, 0); break; case ACKTYPE_EOI: cpu_eoi_map = action->cpu_eoi_map; @@ -921,7 +924,7 @@ static void __do_IRQ_guest(int irq) /* An interrupt may slip through while freeing an ACKTYPE_EOI irq. */ ASSERT(action->ack_type == ACKTYPE_EOI); ASSERT(desc->status & IRQ_DISABLED); - desc->handler->end(irq); + desc->handler->end(irq, vector); return; } @@ -1032,7 +1035,7 @@ static void flush_ready_eoi(void) ASSERT(irq > 0); desc = irq_to_desc(irq); spin_lock(&desc->lock); - desc->handler->end(irq); + desc->handler->end(irq, peoi[sp].vector); spin_unlock(&desc->lock); } @@ -1113,7 +1116,7 @@ static void __pirq_guest_eoi(struct doma if ( action->ack_type == ACKTYPE_UNMASK ) { ASSERT(cpus_empty(action->cpu_eoi_map)); - desc->handler->end(irq); + desc->handler->end(irq, 0); spin_unlock_irq(&desc->lock); return; } @@ -1373,7 +1376,7 @@ static irq_guest_action_t *__pirq_guest_ case ACKTYPE_UNMASK: if ( test_and_clear_bit(pirq, d->pirq_mask) && (--action->in_flight == 0) ) - desc->handler->end(irq); + desc->handler->end(irq, 0); break; case ACKTYPE_EOI: /* NB. If #guests == 0 then we clear the eoi_map later on. */ diff -r 589651f9a8a6 xen/drivers/passthrough/amd/iommu_init.c --- a/xen/drivers/passthrough/amd/iommu_init.c Thu Aug 25 17:50:48 2011 +0100 +++ b/xen/drivers/passthrough/amd/iommu_init.c Fri Aug 26 19:26:59 2011 +0100 @@ -442,7 +442,7 @@ static unsigned int iommu_msi_startup(un return 0; } -static void iommu_msi_end(unsigned int irq) +static void iommu_msi_end(unsigned int irq, u8 vector) { iommu_msi_unmask(irq); ack_APIC_irq(); diff -r 589651f9a8a6 xen/drivers/passthrough/vtd/iommu.c --- a/xen/drivers/passthrough/vtd/iommu.c Thu Aug 25 17:50:48 2011 +0100 +++ b/xen/drivers/passthrough/vtd/iommu.c Fri Aug 26 19:26:59 2011 +0100 @@ -978,7 +978,7 @@ static unsigned int dma_msi_startup(unsi return 0; } -static void dma_msi_end(unsigned int irq) +static void dma_msi_end(unsigned int irq, u8 vector) { dma_msi_unmask(irq); ack_APIC_irq(); diff -r 589651f9a8a6 xen/include/xen/irq.h --- a/xen/include/xen/irq.h Thu Aug 25 17:50:48 2011 +0100 +++ b/xen/include/xen/irq.h Fri Aug 26 19:26:59 2011 +0100 @@ -44,7 +44,7 @@ struct hw_interrupt_type { void (*enable)(unsigned int irq); void (*disable)(unsigned int irq); void (*ack)(unsigned int irq); - void (*end)(unsigned int irq); + void (*end)(unsigned int irq, u8 vector); void (*set_affinity)(unsigned int irq, cpumask_t mask); };