[Xen-devel] Re: [PATCH] IRQ: manually EOI migrating line interrupts

[Keir Fraser <keir@xxxxxxx>]

On 30/08/2011 15:28, "Andrew Cooper" <andrew.cooper3@xxxxxxxxxx> wrote:

>> @@ -1739,6 +1739,14 @@ static void end_level_ioapic_irq (unsign
>>   */
>>      i = IO_APIC_VECTOR(irq);
>>  
>> +    /* Manually EOI the old vector if we are moving to the new */
>> +    if ( vector && i != vector )
>> +    {
>> +        int ioapic;
>> +        for (ioapic = 0; ioapic < nr_ioapics; ioapic++)
>> +            io_apic_eoi(ioapic, i);
>> +    }
>> +

I don't know whether it's worth the effort, but we ought to be able to do
better than this and send EOI to exactly the correct IO-APIC. I think
irq=gsi here? And we should know the gsi_base of every IO-APIC, so we can
work out in fact which pin of which IO-APIC needs clobbering?

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel