Re: [Xen-devel] RE: [PATCH] vpmu: Add processors Westmere E7-8837 and SandyBridge i5-2500 to the vpmu list

[Dietmar Hahn <dietmar.hahn@xxxxxxxxxxxxxx>]

Am 29.08.2011 schrieb ""Shan, Haitao" <haitao.shan@xxxxxxxxx>":
> Hi,Hahn,
> 
> I will have a check tomorrow, though I myself do not own all of the machine 
> now.
> As for the quirk, I don't know whether it is needed by later processors. But 
> as far as I know, it should not harm profiling tools inside guests.

Without the quirk handling for the E7-8837 I could reproduce the same endless
interrupt loop on some processors so that the system must get rebooted like
what we had with the X7542 processor. As far as I know the i5-2500 uses the
same pmu (but with more general usable registers) so I added it to the quirk
handling too.

Dietmar.

> 
> Shan Haitao
> 
> > -----Original Message-----
> > From: Dietmar Hahn [mailto:dietmar.hahn@xxxxxxxxxxxxxx]
> > Sent: Monday, August 29, 2011 8:39 PM
> > To: xen-devel@xxxxxxxxxxxxxxxxxxx
> > Cc: Shan, Haitao
> > Subject: [PATCH] vpmu: Add processors Westmere E7-8837 and SandyBridge
> > i5-2500 to the vpmu list
> > 
> > Hi,
> > 
> > the following patch adds the mentioned processors to the list of vpmu able
> > procs.
> > Maybe some other processors could get added (i3..., i7...), but I have no
> > machines to check this - Haitao?
> > I think this patch would be a candidate for backports to 4.0.3 and 4.1.2.
> > Should I send a patch too?
> > 
> > Thanks.
> > Dietmar.
> > 
> > Signed-off-by: Dietmar Hahn <dietmar.hahn@xxxxxxxxxxxxxx>
> > 
> > Add processors Westmere E7-8837 and SandyBridge i5-2500 to the vpmu list.
> > 
> > diff -r 227130622561 -r 8ae871cf435a xen/arch/x86/hvm/vmx/vpmu_core2.c
> > --- a/xen/arch/x86/hvm/vmx/vpmu_core2.c     Thu Aug 25 12:03:14 2011 +0100
> > +++ b/xen/arch/x86/hvm/vmx/vpmu_core2.c     Mon Aug 29 14:13:44 2011
> > +0200
> > @@ -58,7 +58,8 @@
> >      is_pmc_quirk = 0;
> >      if ( family == 6 )
> >      {
> > -        if ( cpu_model == 46 || cpu_model == 26 )
> > +        if ( cpu_model == 47 || cpu_model == 46 || cpu_model == 42 ||
> > +             cpu_model == 26 )
> >              is_pmc_quirk = 1;
> >      }
> >  }
> > diff -r 227130622561 -r 8ae871cf435a xen/arch/x86/hvm/vpmu.c
> > --- a/xen/arch/x86/hvm/vpmu.c       Thu Aug 25 12:03:14 2011 +0100
> > +++ b/xen/arch/x86/hvm/vpmu.c       Mon Aug 29 14:13:44 2011 +0200
> > @@ -119,7 +119,9 @@
> >              case 23:
> >              case 26:
> >              case 29:
> > +            case 42:
> >              case 46:
> > +            case 47:
> >                  vpmu->arch_vpmu_ops = &core2_vpmu_ops;
> >                  break;
> >              }
> > 
> > --
> > Company details: http://ts.fujitsu.com/imprint.html
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel
> 
> 
-- 
Company details: http://ts.fujitsu.com/imprint.html

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel