Re: [Xen-devel] [PATCH 0 of 3] Some refactoring on xapi-libs and oxenstored

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Sun, 2011-07-31 at 09:59 +0100, Zheng Li wrote:
> These are mostly simplifications plus small bug fixes. 
> 
> Sorry that some of the patches should have been smaller, it's a bit
> too late to break them down. They should be quite safe to apply
> though, as these modifications have been running in our test
> facilities for a few months now.

IMHO it's never too late to break down patches. It should be quite easy
using e.g. emacs diff mode, filterdiff and friends, if you import the
changes into a patch queue first that would probably help too. You can
easily confirm that the end overall result is the same.

In particular the first patch bunches together lots of unrelated fixes
which appear to not overlap terribly much, i.e. you can separate them
out pretty trivially using "hg qdiff path/to/some/file".

Please also expand on your commit messages, e.g. "minor Makefile
cleanup" and "fix small bug in ... binding" are not very informative.
Please describe what the bug is and how your change fixes it. Also it's
not clear that all the changes (in patch 1/3 at least) are actually
covered by your commit messages, although with so many lumped together
it is hard to tell.

Ian.

> Signed-off-by: Zheng Li <zheng.li@xxxxxxxxxxxxx>
> 
> 
>  tools/ocaml/Makefile.rules           |   10 +-
>  tools/ocaml/libs/Makefile            |    4 +-
>  tools/ocaml/libs/eventchn/Makefile   |    1 +
>  tools/ocaml/libs/log/META.in         |    5 -
>  tools/ocaml/libs/log/Makefile        |   44 -----
>  tools/ocaml/libs/log/log.ml          |  258 -----------------------------
>  tools/ocaml/libs/log/log.mli         |   55 ------
>  tools/ocaml/libs/log/logs.ml         |  197 ----------------------
>  tools/ocaml/libs/log/logs.mli        |   46 -----
>  tools/ocaml/libs/log/syslog.ml       |   26 ---
>  tools/ocaml/libs/log/syslog.mli      |   41 ----
>  tools/ocaml/libs/log/syslog_stubs.c  |   75 --------
>  tools/ocaml/libs/uuid/META.in        |    4 -
>  tools/ocaml/libs/uuid/Makefile       |   29 ---
>  tools/ocaml/libs/uuid/uuid.ml        |  100 -----------
>  tools/ocaml/libs/uuid/uuid.mli       |   67 -------
>  tools/ocaml/libs/xb/Makefile         |    2 +-
>  tools/ocaml/libs/xc/META.in          |    2 +-
>  tools/ocaml/libs/xc/Makefile         |    2 +-
>  tools/ocaml/libs/xc/xc.ml            |   14 +-
>  tools/ocaml/libs/xc/xc.mli           |    9 +-
>  tools/ocaml/libs/xc/xc_stubs.c       |   10 +-
>  tools/ocaml/xenstored/Makefile       |    4 -
>  tools/ocaml/xenstored/connection.ml  |    5 +
>  tools/ocaml/xenstored/connections.ml |    7 +-
>  tools/ocaml/xenstored/disk.ml        |    2 +-
>  tools/ocaml/xenstored/domain.ml      |    2 +-
>  tools/ocaml/xenstored/domains.ml     |    6 +-
>  tools/ocaml/xenstored/logging.ml     |  302 
> ++++++++++++++++++----------------
>  tools/ocaml/xenstored/perms.ml       |    8 +-
>  tools/ocaml/xenstored/process.ml     |   20 +-
>  tools/ocaml/xenstored/quota.ml       |    2 +-
>  tools/ocaml/xenstored/store.ml       |    2 +-
>  tools/ocaml/xenstored/xenstored.conf |   15 +-
>  tools/ocaml/xenstored/xenstored.ml   |   62 +++---
>  tools/python/xen/lowlevel/xs/xs.c    |   16 +-
>  tools/xenstore/xenstore_client.c     |   29 +-
>  tools/xenstore/xs.c                  |   16 +-
>  tools/xenstore/xs.h                  |    1 +
>  39 files changed, 309 insertions(+), 1191 deletions(-)
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel