Re: [Xen-devel] [PATCH] libxl: add a vkbd device to HVM guests by default

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2011-06-24 at 17:29 +0100, Stefano Stabellini wrote:
> PV on HVM drivers can connect to the vkbd device to receive mouse and
> keyboard events from Qemu. The advantage over USB is that vkbd doesn't
> require frequent wakeups in Qemu.

Do we need an unplug protocol in order to stop these frequent wakeups?

Do frontends/guests generally cope with two keyboards correctly?
(whatever correctly means, I guess it's not obvious once you have a vfb
as well as emulated VGA).

> 
> Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
> 
> diff -r f17956fd6976 tools/libxl/libxl_create.c
> --- a/tools/libxl/libxl_create.c      Fri Jun 17 16:10:48 2011 +0000
> +++ b/tools/libxl/libxl_create.c      Fri Jun 24 16:19:29 2011 +0000
> @@ -469,6 +469,7 @@ static int do_domain_create(libxl__gc *g
>      }
>      if (d_config->c_info.hvm) {
>          libxl_device_console console;
> +        libxl_device_vkb vkb;
>  
>          ret = init_console_info(&console, 0);
>          if ( ret )
> @@ -476,6 +477,11 @@ static int do_domain_create(libxl__gc *g
>          libxl__device_console_add(gc, domid, &console, &state);
>          libxl_device_console_destroy(&console);
>  
> +
> +        memset(&vkb, 0x00, sizeof(vkb));
> +        libxl_device_vkb_add(ctx, domid, &vkb);
> +        libxl_device_vkb_destroy(&vkb);
> +
>          dm_info->domid = domid;
>          ret = libxl__create_device_model(gc, dm_info,
>                                          d_config->disks, d_config->num_disks,
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel