Re: [Xen-devel] [PATCH] no-fork option for tapdisk2 debugging

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Philipp Hahn writes ("[Xen-devel] [PATCH] no-fork option for tapdisk2 
debugging"):
> For debugging tapdisk2 it would be nice if forking into the background could 
> be disabled by passing some command line argument. The attached patch adds 
> such an option (-n).

This seems reasonable.

> The second patch re-indents four un-changed lines.

That should be folded into the first patch, which otherwise leaves the
indentation wrong.

> It would be nice if this could be included into the source core repository.

Also, you to add a Signed-off-by line to your patch to signify its
copyright status (see below).

Thanks,
Ian.

>From Documentation/SubmittingPatches in the Linux kernel tree:
 
        Developer's Certificate of Origin 1.1
 
        By making a contribution to this project, I certify that:
 
        (a) The contribution was created in whole or in part by me and I
            have the right to submit it under the open source license
            indicated in the file; or
 
        (b) The contribution is based upon previous work that, to the best
            of my knowledge, is covered under an appropriate open source
            license and I have the right under that license to submit that
            work with modifications, whether created in whole or in part
            by me, under the same open source license (unless I am
            permitted to submit under a different license), as indicated
            in the file; or
 
        (c) The contribution was provided directly to me by some other
            person who certified (a), (b) or (c) and I have not modified
            it.
 
        (d) I understand and agree that this project and the contribution
            are public and that a record of the contribution (including all
            personal information I submit with it, including my sign-off) is
            maintained indefinitely and may be redistributed consistent with
            this project or the open source license(s) involved.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel