[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 1 of 4] fix state

To: Zhigang Wang <zhigang.x.wang@xxxxxxxxxx>
From: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Date: Fri, 17 Jun 2011 18:25:23 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Fri, 17 Jun 2011 10:26:08 -0700
List-id: Xen developer discussion <xen-devel.lists.xensource.com>

Zhigang Wang writes ("[Xen-devel] [PATCH 1 of 4] fix state"):
> -    else if [[ "$1" =~ '(name' ]]; then
> +    else if [[ "$1" =~ $name_re ]]; then

This is really shockingly ugly.  What would be wrong with using case ?

Since this is a bash-specific script already, we can use
${..#...} ${..##...} ${..%...} ${..%%...} too.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

References:
- [Xen-devel] [PATCH 0 of 4] fix xendomains service
  - From: Zhigang Wang
- [Xen-devel] [PATCH 1 of 4] fix state
  - From: Zhigang Wang

Prev by Date: Re: [Xen-devel] [PATCH] add a way to disable xen's udev script.
Next by Date: [Xen-devel] Re: [PATCH] libxl: initialize domid to 0 in libxl__create_stubdom
Previous by thread: [Xen-devel] [PATCH 1 of 4] fix state
Next by thread: [Xen-devel] [PATCH 2 of 4] fix not functional eval
Index(es):
- Date
- Thread

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.