[Xen-devel] Possible bug in XendConfig.py

[Alexander Fittkau <alexander.fittkau@xxxxxxxxxxxxxx>]

Hi, all!

While poking around in various Xend*.py sources (Xen 4.0.1, Debian
Squeeze) I discovered a possible Bug in XendConfig.py. More precisely in
the method to_sxp of the class XendConfig. It exposes an optional
parameter "domain=None". But further checks regarding the presence of
this parameter check against member-functions such as domain.getDomid()
or domain._stateGet() which raise an Exception if the parameter is
'None'. The docstring states that this parameter is optional, but
further handling of it either suggest it is not, or the checks are
mistakenly made against methods of 'domain' instead of domain itself.

The offending lines of code in XendConfig.py are:

1095: check against domain.getDomid()

1135: Usage of domain._stateGet()

1137: check against domain.getDomid()

In line 1140 the check is correctly made against 'domain' itself and the 
corresponding if-block only executes if domain was set.
Is this patched in newer versions, can I just add the correct checks or 
will this break something somewhere else?
Regards,
Alx.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel