Re: [Xen-devel] [PATCH] pci_remove_device: fix linked list discipline

[Tim Deegan <Tim.Deegan@xxxxxxxxxx>]

At 16:41 +0100 on 20 May (1305909715), Jan Beulich wrote:
> > diff -r f531ed84b066 -r 7b12c46b1877 xen/drivers/passthrough/pci.c
> > --- a/xen/drivers/passthrough/pci.c Tue May 17 17:32:19 2011 +0100
> > +++ b/xen/drivers/passthrough/pci.c Wed May 18 09:52:20 2011 +0100
> > @@ -173,11 +173,11 @@ out:
> >  
> >  int pci_remove_device(u8 bus, u8 devfn)
> >  {
> > -    struct pci_dev *pdev;
> > +    struct pci_dev *pdev, *tmp;
> >      int ret = -ENODEV;
> >  
> >      spin_lock(&pcidevs_lock);
> > -    list_for_each_entry ( pdev, &alldevs_list, alldevs_list )
> > +    list_for_each_entry_safe ( pdev, tmp, &alldevs_list, alldevs_list )
> 
> Somehow I overlooked this patch when it was sent - looking at the
> code it modifies I can't see why the ..._safe() variant is necessary
> here, as there's a break statement following the list deletion.

Ah - good point.  I'll go back to the crash report I thought this fixed
and take another look. :)

Cheers,

Tim.

-- 
Tim Deegan <Tim.Deegan@xxxxxxxxxx>
Principal Software Engineer, Xen Platform Team
Citrix Systems UK Ltd.  (Company #02937203, SL9 0BG)

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel