[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 29 of 45] gcc-4.6 compile fix: xen/arch/x86/cpu/intel.c

  • To: Jan Beulich <JBeulich@xxxxxxxxxx>, Olaf Hering <olaf@xxxxxxxxx>
  • From: Keir Fraser <keir@xxxxxxx>
  • Date: Fri, 20 May 2011 09:38:50 +0100
  • Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
  • Delivery-date: Fri, 20 May 2011 01:39:39 -0700
  • Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:user-agent:date:subject:from:to:cc:message-id:thread-topic :thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; b=G772ZPxght3nv7piOFY0lrBCJw9QlVt8/HSha1DZZGfVjcV1dzUgBzF6keXwBzfdmo VnOXLdb5oim0esEmGhigHobLyjD7piiyqjPxFvQ7sZUsNqhHiBkr59fiqar+VO7UwdSd fxZtJ/c7bKYWkKV7a2+yPYI4Z0iLE+hlqhJEA=
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: AcwWyVeNfY+RgOZQq0OxWO2JlG0f3w==
  • Thread-topic: [Xen-devel] [PATCH 29 of 45] gcc-4.6 compile fix: xen/arch/x86/cpu/intel.c

On 20/05/2011 08:55, "Jan Beulich" <JBeulich@xxxxxxxxxx> wrote:

>> intel.c: In function 'set_cpuidmask':
>> intel.c:36:14: error: variable 'extra' set but not used
>> [-Werror=unused-but-set-variable]
> No, please don't push this - it was a mistake that "extra" wasn't
> used, and 
> http://lists.xensource.com/archives/html/xen-devel/2011-05/msg00753.html
> corrects this.

Ha, too late, that was one of the patches I cherry picked as a reasonable
cleanup. Your patch will have to reintroduce "extra".

 -- Keir

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.