[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] [PATCH 24 of 45] gcc-4.6 compile fix: xen/arch/x86/msi.c


  • To: xen-devel@xxxxxxxxxxxxxxxxxxx
  • From: Olaf Hering <olaf@xxxxxxxxx>
  • Date: Thu, 19 May 2011 21:05:43 +0200
  • Delivery-date: Thu, 19 May 2011 12:29:43 -0700
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>

# HG changeset patch
# User Olaf Hering <olaf@xxxxxxxxx>
# Date 1305824409 -7200
# Node ID d657cd6182d517b8b5e0fffb0f34ea451f49c916
# Parent  452ca03a71814742f94213554399f6cfbf350046
gcc-4.6 compile fix: xen/arch/x86/msi.c

msi.c: In function '__pci_disable_msi':
msi.c:749:9: error: variable 'control' set but not used 
[-Werror=unused-but-set-variable]

(Is this a dummy read before doing the disable?)

Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>

diff -r 452ca03a7181 -r d657cd6182d5 xen/arch/x86/msi.c
--- a/xen/arch/x86/msi.c        Thu May 19 19:00:08 2011 +0200
+++ b/xen/arch/x86/msi.c        Thu May 19 19:00:09 2011 +0200
@@ -745,17 +745,8 @@ static int __pci_enable_msi(struct msi_i
 static void __pci_disable_msi(struct msi_desc *entry)
 {
     struct pci_dev *dev;
-    int pos;
-    u16 control;
-    u8 bus, slot, func;
 
     dev = entry->dev;
-    bus = dev->bus;
-    slot = PCI_SLOT(dev->devfn);
-    func = PCI_FUNC(dev->devfn);
-
-    pos = pci_find_cap_offset(bus, slot, func, PCI_CAP_ID_MSI);
-    control = pci_conf_read16(bus, slot, func, msi_control_reg(pos));
     msi_set_enable(dev, 0);
 
     BUG_ON(list_empty(&dev->msi_list));

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.