[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH]tools/libxl: fix a bug in libxl__build_device_model_args_new. info->vncpasswd can't be empty if info->vncpasswd != NULL
- To: Christoph Egger <Christoph.Egger@xxxxxxx>, ian.campbell@xxxxxxxxxx
- From: ZhouPeng <zpengxen@xxxxxxxxx>
- Date: Fri, 15 Apr 2011 17:36:57 +0800
- Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
- Delivery-date: Fri, 15 Apr 2011 02:38:57 -0700
- Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=IHPkpnxYdAWTxKGDl1tHEYvNhSucQ7v7msszDoOrLwXUe1aEfjOvTSfj4nuQgNNfbB tSI6HrteZROxJuaNM2acWp/19V4OAlfVQok8B46cqmNCaYJngpL00IJk26ta/ARQhVII gwgmTQ3pX7HQvePXcNQrQ1xNqdIfw7CS+z6f8=
- List-id: Xen developer discussion <xen-devel.lists.xensource.com>
2011/4/15 Christoph Egger <Christoph.Egger@xxxxxxx>
On 04/15/11 10:33, ZhouPeng wrote:
Signed-off-by: Zhou Peng<zhoupeng@xxxxxxxxxxxxxxx>
tools/libxl: fix a bug in libxl__build_device_model_args_new. info->vncpasswd can't be empty if info->vncpasswd != NULL
vncpasswd=''
in the guest config file.
" if (info->vncpasswd&& info->vncpasswd[0]) “ can
vncpasswd='' in guest cfg file, when using upstream-qemu-xen
and block vncpasswd='passwd'
Can it be reasonable?
Christoph
diff -r 3f00c5faa12a tools/libxl/libxl_dm.c
--- a/tools/libxl/libxl_dm.c Wed Apr 13 16:10:26 2011 +0100
+++ b/tools/libxl/libxl_dm.c Fri Apr 15 09:45:43 2011 +0800
@@ -209,7 +209,7 @@ static char ** libxl__build_device_model
int display = 0;
const char *listen = "127.0.0.1";
- if (info->vncpasswd&& info->vncpasswd[0]) {
+ if (info->vncpasswd&& !info->vncpasswd[0]) {
assert(!"missing code for supplying vnc password to qemu");
}
flexarray_append(dm_args, "-vnc");
--
Zhou Peng
Operating System Technology Group
Institute of Software, the Chinese Academy of Sciences (ISCAS)
<mailto:ailvpeng25@xxxxxxxxx>
--
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Einsteinring 24, 85689 Dornach b. Muenchen
Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
--
Zhou Peng
Operating System Technology Group
Institute of Software, the Chinese Academy of Sciences (ISCAS)
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
