Re: [Xen-devel] [PATCH 09 of 30] tools: blktap2: copy xenstore/hashtable.h into blktap2

[Shriram Rajagopalan <rshriram@xxxxxxxxx>]

On Mon, Mar 21, 2011 at 11:03 AM, Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx> wrote:

Ian Campbell writes ("[Xen-devel] [PATCH 09 of 30] tools: blktap2: copy xenstore/hashtable.h into blktap2"):

> tools: blktap2: copy xenstore/hashtable.h into blktap2
>
> hashtable.c has already been copied, forked and modified, there
> doesn't seem much point in avoiding the same for the header until
> someone feels motivated to properly refactor.

Before we make this any worse, perhaps we should at least leave a
comment in every copy of hashtable.c referring to every other clone ?

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

copying hashtable.h alone wont suffice.
hashtable_itr.h in blktap2/drivers includes hashtable_private.h in xenstore/

And a diff -wu blktap2/drivers/hashtable.c xenstore/hashtable.c shows no functional
difference between the two versions.
  How about pulling the hashtable.h, hashtable.c, hashtable_private.h from xenstore/
and hashtable_itr.[h,c], hashtable_utility.[h,c] from blktap2/drivers/ into one common
separate area, like utils/ or something.

Also, I suggest moving all code from hashtable_itr.c and hashtable_utility.c
into hashtable.c (and adding the appropriate declarations to hashtable.h). The copyrights
and attributions in the files seem to be the same. We could get rid of all the clutter and
have just 3 files related to hashtable, common to both xenstore and blktap2/drivers/.

shriram

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel