Re: [Xen-devel] [PATCH] x86/mce: CPU notifiers must not be registered a second time during resume

["Jan Beulich" <JBeulich@xxxxxxxxxx>]

>>> On 18.03.11 at 16:43, Keir Fraser <keir.xen@xxxxxxxxx> wrote:
> On 18/03/2011 15:07, "Jan Beulich" <JBeulich@xxxxxxxxxx> wrote:
> 
>> While c/s 22964:f71212f712fd and 23051:93c864c16ab1 fixed issues with
>> CPU onlining, they introduced a problem with resume: mcheck_init() is
>> also being called on that path, and hence checking whether it's running
>> on CPU 0, which is generally not a really good thing, is particularly
>> inappropriate here.
> 
> Just have a 'static bool_t early_init_done' or similar in
> intel_mcheck_init().

And another in mcheck_init(). If the proliferates, an alternative I
would like a little better would be to just have a global variable (e.g.
extending early_boot).

> if ( !early_init_done ) {
>  BUG_ON(smp_processor_id() != 0);
>  ...
>  early_init_done = 1;
> }
> 
> It's clearer anyway -- we're simply protecting one-time-only early-boot-time
> initialisation stuff.

What's wrong with doing the protection by passing down the
necessary information?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel