[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] xen-unstable: build fails



>>> On 17.03.11 at 11:29, Juergen Gross <juergen.gross@xxxxxxxxxxxxxx> wrote:
> On 03/17/11 11:13, Jan Beulich wrote:
>>>>> On 17.03.11 at 09:59, Juergen Gross<juergen.gross@xxxxxxxxxxxxxx>  wrote:
>>> The problem is still the relative XEN_ROOT specification.
>>> Or the missing .config under XEN_ROOT, so creating this file solves my
>>> problem. :-)
>>
>> I'd favor the latter, e.g. by adding something like
>>
>> cfg-create := $(shell touch $(XEN_ROOT)/.config)
>>
>> to ./Config.mk, or putting the include in a conditional instead
>> of making use of -include.
> 
> As short time measure this seems to be okay.
> 
> On the long run I'd prefer to use absolute paths only. Otherwise you've
> always a risk to use something from outside the intended build environment.
> 
> XEN_ROOT = $(abspath ../..)
> 
> seems not too hard to use instead of
> 
> XEN_ROOT = ../..

Except that make 3.80 doesn't support this, and that make version
is - to my knowledge - still in quite wide spread use. But that can
probably be overcome with a fallback implementation (which newer
make just wouldn't use).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.