Re: [Xen-devel] xen-unstable: build fails

[Keir Fraser <keir.xen@xxxxxxxxx>]

On 16/03/2011 13:50, "Juergen Gross" <juergen.gross@xxxxxxxxxxxxxx> wrote:

> Hi,
> 
> I've just set up a machine with OpenSuse 11.4 and tried to build Xen.
> 
> Under root I did:
> 
> hg clone http://xenbits.xensource.com/xen-unstable.hg
> cd xen-unstable.hg
> make xen
> 
> The make failed with:
> 
> make[4]: Entering directory `/root/xen-unstable.hg/xen/arch/x86/boot'
> RELOC=0x7c000 make -f build32.mk reloc.S
> make[5]: Entering directory `/root/xen-unstable.hg/xen/arch/x86/boot'
> make[5]: *** ../../../../.config: Is a directory.  Stop.

Seems to me that /root/xen-unstable.hg/xen/arch/x86/boot/../../../../.config
resolves to /root/xen-unstable.hg/.config. Which is what is intended. Also I
tried creating a .config dir just outside my own xen-unstable repo, and
rebuoilding the hypervisor, and it works okay for me.

> The reason seems to be a directory /root/.config which isn't present on my
> other machines.

We shouldn't be referring outside the repository. AFAICS the above logging
doesn't indicate that we are. I don't understand why you are getting that
error. I haven't been able to reproduce it.

> fails in a similar way. Many Makefiles seem to contain lines like:
> 
> XEN_ROOT=../..
> 
> which is a really bad idea in my opinion. XEN_ROOT should only be set, if it
> is not yet defined.

Why? It's private to our build system. We don't want the user screwing with
it. I also don't see why relative paths within our repository should be
avoided, as you try to do in your alternative formulation.

 -- Keir

> I'd suggest to use
> 
> XEN_ROOT ?= $(PWD)/../..
> 
> instead. A patch is easily made, but affects ca. 100 Makefiles. And this
> change could break the possibility to just do a "make" in a subdirectory.
> 
> Opinions?
> 
> 
> Juergen



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel