Re: [Xen-devel] [PATCH 4/12] VTPM mini-os: Mini-os machine specific headers

[Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>]

Matthew Fioravante, le Mon 14 Mar 2011 13:02:24 -0400, a écrit :
> Which part? The check for gcc version >= 4.3 or the #defines for bswap_XX?
> 
> I think its correct

The 64bit #define.  If it's really meant to be using __builtin_bswap32 instead 
of
__builtin_bswap64, a comment should say why :)

> On 03/11/2011 07:31 PM, Samuel Thibault wrote:
> >Matthew Fioravante, le Fri 11 Mar 2011 17:44:01 -0500, a écrit :
> >>+/* Use gcc optimized versions if they exist */
> >>+#if __GNUC__>  4 || (__GNUC__ == 4&&  __GNUC_MINOR__>= 3)
> >>+#define bswap_32(v) __builtin_bswap32(v)
> >>+#define bswap_64(v) __builtin_bswap32(v)
> >Typo here, right?

Samuel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel