Re: [Xen-devel] [PATCH 3/12] VTPM mini-os: Add ioread() and iowrite() functions to mini-os

[Matthew Fioravante <matthew.fioravante@xxxxxxxxxx>]

Yeah your right, sorry about that! Heres a patch that applies on top of 
the previous one to add volatile.
Signed off by: Matthew Fioravante <matthew.fioravante@xxxxxxxxxx>

On 03/11/2011 07:29 PM, Samuel Thibault wrote:
> Matthew Fioravante, le Fri 11 Mar 2011 17:38:32 -0500, a écrit :
> > Mini-os currently doesn't have very many facilities for reading and
> > writing to hardware io memory. This patch addes  a new header file
> > iorw.h which when included gives access to
> > the ioread8(), iread32(), iowrite8(), iowrite32() family of functions.
> > +void iowrite8(void* addr, uint8_t val)
> > +{
> > +   *((uint8_t*)addr) = val;
> > +}
> > +void iowrite32(void* addr, uint32_t val)
> > +{
> > +   *((uint32_t*)addr) = val;
> > +}
> Don't you need a volatile qualifier on the cast pointer to not let the
> compiler optimize it away?
>
> Samuel

Attachment: 3-minios-iorw.patch2
Description: Text document

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel