Re: [Xen-devel] [PATCH 0/12] VTPM mini-os: TPM device drivers for mini-os

[Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>]

Matthew Fioravante, le Fri 11 Mar 2011 17:50:43 -0500, a écrit :
> This patch adds 3 new drivers to mini-os
> 
> tpmfront: Paravirtualized tpm driver that can speak to mini-os tpmback 
> and linux tpmbk
> tpmback: Paravirtualized tpm backend driver that can speak to mini-os 
> tpmfront and linux tpm_xenu
> tpm_tis: Hardware tpm driver. Should work with any TPM device compliant 
> with the 1.2 spec. Requires io memory passthrough.
> 
> Signed off by: Matthew Fioravante <matthew.fioravante@xxxxxxxxxx>

I don't have the time to review the driver code in details, but the
overall shape and interaction with the rest of mini-os looks good to me.

> @@ -177,6 +179,7 @@
>       } tap;
>       struct {
>           struct blkfront_dev *dev;
> +         off_t offset;
>       } blk;
>       struct {
>           struct kbdfront_dev *dev;

This seems like an unrelated change, right?

Samuel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel