[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] Use timeout on xenstore read_reply to avoid task hunging


  • To: Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>
  • From: Frank Pan <frankpzh@xxxxxxxxx>
  • Date: Thu, 10 Mar 2011 18:54:32 +0800
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Jeremy Fitzhardinge <Jeremy.Fitzhardinge@xxxxxxxxxx>
  • Delivery-date: Thu, 10 Mar 2011 02:56:05 -0800
  • Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=G4v9gkVXs3g3xAhdmYr6QTn8aowJPeVRj15GibeGqqlnI+Tlnj6AKq3I05rhKKtTCB d7zbTAH1f6wVevWWt4VjdyROwce19GJAbzUYo5Ij9CvuaQdphXbp1M4XdzJ+yT6rc4m8 kKeN3Y8AEZjDGVRV+oBl6qQBHTuyp4oC96+nc=
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>

> I think this is preferable to requiring all clients be reworked to
> handle a timeout event which they aren't currently expecting.

> Rather than have all xenbus clients expect and handle an arbitrary
> timeout we should provide a new interface to in-kernel users of xenbus
> which includes a timeout parameter, e.g. foo_timeout. (assuming there
> are in kernel users who could do anything sane with a timeout, if not
> then we shouldn't bother with the interface).

> For userspace clients I think we would probably be better off making
> sure that poll/select work properly than trying to find a way to expose
> timeouts of this sort, that combined with making the sleeps
> interruptible, would cover the problems we care about, I think.

How many clients are there? Is it possible to change them all?

Poll/select sounds great, but it may change the current xenbus protocol.
Also, if the protocol is changing, i think design a method to
determine whether xenstored is up is needed.

Can we alter xenbus protocol?

-- 
æéç, Frank Pan

Computer Science and Technology
Tsinghua University

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.