Re: [Xen-devel] [PATCH 2 of 8] x86: add explicit size suffixes to some assembly instructions

[Tim Deegan <Tim.Deegan@xxxxxxxxxx>]

At 09:27 +0000 on 08 Mar (1299576427), Jan Beulich wrote:
> >>> On 07.03.11 at 12:26, Tim Deegan <Tim.Deegan@xxxxxxxxxx> wrote:
> >--- a/xen/arch/x86/x86_emulate/x86_emulate.c Mon Mar 07 11:21:11 2011 +0000
> >+++ b/xen/arch/x86/x86_emulate/x86_emulate.c Mon Mar 07 11:21:11 2011 +0000
> >@@ -2678,7 +2678,7 @@ x86_emulate(
> >                 emulate_fpu_insn_memsrc("fiaddl", src.val);
> >                 break;
> >             case 1: /* fimul m64i */
> >-                emulate_fpu_insn_memsrc("fimul", src.val);
> >+                emulate_fpu_insn_memsrc("fimuls", src.val);
> 
> fimull.

fimuls is what the previous code generates, but it does look like that
was wrong.  I'll fix it, thanks.

Tim.

> >                 break;
> >             case 2: /* ficom m64i */
> >                 emulate_fpu_insn_memsrc("ficoml", src.val);
> 
> (Side note: The comments in this section are all wrong - they
> should say "m32i"; there are no 64-bit integer operations
> other than loads and stores.)



-- 
Tim Deegan <Tim.Deegan@xxxxxxxxxx>
Principal Software Engineer, Xen Platform Team
Citrix Systems UK Ltd.  (Company #02937203, SL9 0BG)

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel