Re: [Xen-devel] [PATCH 8 of 8] xen: add "clang=y" option to build Xen with clang/llvm instead of gcc

[Tim Deegan <Tim.Deegan@xxxxxxxxxx>]

At 17:01 +0000 on 07 Mar (1299517318), Keir Fraser wrote:
> On 07/03/2011 16:29, "Tim Deegan" <Tim.Deegan@xxxxxxxxxx> wrote:
> 
> > At 14:54 +0000 on 07 Mar (1299509669), Ian Campbell wrote:
> >> Is it worth arranging for "gcc := y" when clang is not enabled? Then a
> >> whole bunch of this sort of thing devolves into the
> >> CFLAGS-$(a-particular-cc) += -Wfoo
> >> pattern.
> > 
> > Something like the attached?  It tidies up four such ifeqs, at the cost
> > of one new one to define $(gcc).
> > (4 files changed, 17 insertions(+), 16 deletions(-))
> 
> This looks like a definite improvement in readability, to me. I'd like it to
> be applied.

Done (I'm interpreting this as an Acked-by:).

Tim.

-- 
Tim Deegan <Tim.Deegan@xxxxxxxxxx>
Principal Software Engineer, Xen Platform Team
Citrix Systems UK Ltd.  (Company #02937203, SL9 0BG)

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel