[Xen-devel] Re: [PATCH] Make explicit message when guest failed to suspend

[Frank Pan <frankpzh@xxxxxxxxx>]

> This is a bug in Xend, it should never enter an infinite loop regardless
> of guest behaviour. The code certainly appears to expect to be managing
> a timeout, perhaps it has bitrotted?
>
> I don't think you can change the xenbus protocol in this way without
> further rationale regarding it's correctness.
>
> Perhaps a separate control/shutdown-error key? The message written
> should be more verbose than just "failed" if/when more specific
> information is available to the kernel.

FP: Maybe I should seperate it into 2 patches? One for bug fixing, the
other for new protocol?

> In particular you need to consider and explain how it remains compatible
> with a new kernel running on older toolstacks and vice versa.
>

FP: Right. This is something I haven't considered yet.

-- 
Frank Pan

Computer Science and Technology
Tsinghua University

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel