Re: [Xen-devel] [PATCH] amd-k8-mce: remove a stray break statement

[Keir Fraser <keir.xen@xxxxxxxxx>]

On 23/02/2011 11:24, "Jan Beulich" <JBeulich@xxxxxxxxxx> wrote:

> This was a leftover of converting from a switch to an if/else somewhere
> between 3.4 and 4.0.

So the patch is for 4.0-testing and unstable?

 -- Keir

> It also looks suspicious that MCEQUIRK_K7_BANK0 is not actually used
> anywhere. Perhaps amd_k7_mcheck_init() and amd_k8_mcheck_init() were
> intended to get (partially) folded?
> 
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxxxx>
> 
> --- a/xen/arch/x86/cpu/mcheck/amd_k8.c
> +++ b/xen/arch/x86/cpu/mcheck/amd_k8.c
> @@ -92,7 +92,6 @@ enum mcheck_type amd_k8_mcheck_init(stru
> /* Enable error reporting of all errors */
> wrmsrl(MSR_IA32_MCx_CTL(i), 0xffffffffffffffffULL);
> wrmsrl(MSR_IA32_MCx_STATUS(i), 0x0ULL);
> -   break;
> }
> }
>  
> 
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel