Re: [Xen-devel] [PATCH] x86: suppress HPET broadcast initialization in the presence of ARAT

["Jan Beulich" <JBeulich@xxxxxxxxxx>]

>>> On 12.02.11 at 08:35, Keir Fraser <keir@xxxxxxx> wrote:
> On 12/02/2011 07:15, "Wei, Gang" <gang.wei@xxxxxxxxx> wrote:
> 
>> Jan Beulich wrote on 2011-02-10:
>>> This follows Linux commit 39fe05e58c5e448601ce46e6b03900d5bf31c4b0,
>>> noticing that all this setup is pointless when ARAT support is there,
>>> and knowing that on SLED11's native kernel it has actually caused S3 resume
>>> issues.
>>> 
>> 
>> Although this patch was already checked in, I still have to say it is not
>> necessary for Xen. Because hpet_broadcast_init() fn is only called if
>> (xen_cpuidle && !boot_cpu_has(X86_FEATURE_ARAT)) in disable_pit_irq(). Of
>> course I agree to keep it as a never used double check.
> 
> Hmm I didn't spot that. Actually it is part of a more complex series of
> checks in the caller, so I wonder whether repeating just that one check in
> the function itself really makes much sense. I'm somewhat inclibned to
> revert it.

Yes, revert it - somehow I managed to not notice we do this check
already.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel