[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] [PATCH] libxl: do not call libxl__file_reference_unmap two times



Fix double free due to libxl__file_reference_unmap(&info->kernel) called
multiple times: first at the end of libxl__domain_build and then in
libxl_domain_build_info_destroy.

Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>

diff -r 19b2424be183 tools/libxl/libxl_create.c
--- a/tools/libxl/libxl_create.c        Thu Feb 10 09:02:50 2011 +0000
+++ b/tools/libxl/libxl_create.c        Fri Feb 11 13:43:34 2011 +0000
@@ -196,9 +196,6 @@ int libxl__domain_build(libxl_ctx *ctx, 
     }
     ret = libxl__build_post(ctx, domid, info, state, vments, localents);
 out:
-    libxl__file_reference_unmap(&info->kernel);
-    if (!info->hvm)
-           libxl__file_reference_unmap(&info->u.pv.ramdisk);
 
     libxl__free_all(&gc);
     return ret;

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.