RE: [Xen-devel] [PATCH]x86:x2apic: Disable x2apic on x86-32 permanently

["Wei, Gang" <gang.wei@xxxxxxxxx>]

Jan Beulich wrote on 2011-02-09:
>>>> On 09.02.11 at 07:57, "Wei, Gang" <gang.wei@xxxxxxxxx> wrote:
>> Jan Beulich wrote on 2011-01-31:
>>> How does this (namely the x2apic_enabled part) play together with
>>> the selection of the APIC driver, which in this case would have
>>> happened quite a bit earlier (from generic_apic_probe())?
>>> 
>>> I would therefore think that this change really belongs into
>>> check_x2apic_preenabled().
>> 
>> It is really a problem. But I do think we shall simply remove below
>> line from check_x2apic_preenabled() fn:
>> 
>>          genapic = apic_x2apic_probe();
>> The same line exists in x2apic_bsp_setup() fn.
> 
> No, that would be exactly the wrong way round - we need genapic to be
> set early in case x2apic was pre-enabled (see -unstable c/s 22707).

I could not get the reason to set genapic as x2apic in case x2apic was 
pre-enabled while referring to c/s 22707. Genapic->xxx was never called before 
calling x2apic_bsp_setup(). Are you trying to keep consistence (x2apic 
pre-enabled, so genapic have to be x2apic as early as possible)?

Jimmy



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel